Fix sweep() tagEnd #7870
Draft
Fix sweep() tagEnd #7870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Instrumentation Performance ReportMerging #7870 will not alter performanceComparing Summary
Footnotes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7695
Not ready yet. Engine error.
This PR tries to use the ID of the sketch on the face, rather than the original solid's sketch ID. As you can see from the screenshot, this almost works. The
upperSectionstarts from the plane of the bent section, which is what we want. But there's some kind of internal engine error when getting theSolid3dGetAdjacencyInfoof the sketch ID. Moving the rectangle center doesn't fix it.